Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-inputs): allow value of type TextFieldValue #181

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat(text-inputs): allow value of type TextFieldValue #181

merged 2 commits into from
Nov 21, 2023

Conversation

dimitriz09
Copy link
Contributor

@dimitriz09 dimitriz09 commented Nov 6, 2023

Changes description πŸ§‘β€πŸ’»

Allow the usage of TextFieldValue in text inputs Outlined and Filled. Doesn't make sense in dropdown as selection is not possible.

Context πŸ€”

I have an edit field for phone number, which auto formats number as it is typed.
When the auto formats adds a space between digits block (like in french phone numbers) or a dash (like in US phone numbers), the actual value length is incrase by 2 (the added separator, and the actual digit typed) but unfortunately, the cursor only only registers one more char, i would need to force it to the end, but for that, i need the material impl using TextFieldValue instead of basic String

Closes #180

Checklist βœ…

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots πŸ“Έ

image

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

@dktbitrise
Copy link

You can download the apk here :

@dimitriz09 dimitriz09 marked this pull request as ready for review November 15, 2023 10:29
@dimitriz09 dimitriz09 requested review from ManonPolle and a team as code owners November 15, 2023 10:29
Copy link

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dktbitrise
Copy link

@ManonPolle ManonPolle merged commit eabca80 into Decathlon:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(textinputs): allow us handle cursor position in text inputs
4 participants