ReactiveExtensions for CBPeripheral, CBCentralManager and CBPeripheralManager #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BondTests target removed for CBCentralManager.swift, CBPeripheral.swift and CBPeripheralManager.swift
…tooth-extensions * commit '05df822b7046b4cd45412decc2587daf0e7f218b': Bump version Add a method that can replace items of a section. Bump version Fix compiler warnings when building with Xcode 10.2 (DeclarativeHub#607) Make Array2D.Section initializer public
|
This PR looks very nice, and it would be great to have this as part of the Bond project, but until SPM is ready for iOS it's just too complicated to maintain multiple targets. We would need another target in order not to impose CoreBluetooth dependency on other users. If you are up for it, I'd suggest you make this a Community extension. When we get SPM, we can rework it into a target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.