Skip to content

Adding local runner functionality for pytest and adding file existence test case #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

taha-abdullah
Copy link
Contributor

adding local runner functionality to pytest workflow:

  • added new workflow 'pytest_local.yaml' to run pytest on a local runner
  • added environment variables for subject directory and subject id

adding a new test to check for file existence in brainprint output

  • added new pytest to check if all required files exist in the brainprint output
  • removed comments from pytest_local.yaml

Notes:

  • local runner needs to be provisioned on the repository with the necessary environment variables for this workflow to work

- added new workflow 'pytest_local.yaml' to run pytest on a local runner

- added environment variables for subject directory and subject id

Notes:

- local runner needs to be provisioned on the repository with the necessary environment variables for this workflow to work
- added new pytest to check if all required files exist in the brainprint output

- removed comments from pytest_local.yaml
@taha-abdullah
Copy link
Contributor Author

@kdiers requesting review

@kdiers kdiers marked this pull request as ready for review July 3, 2024 08:42
@kdiers
Copy link
Collaborator

kdiers commented Jul 3, 2024

Thanks for updating the tests and creating the runner file. We are still considering to have online / remote tests rather than local tests, so there might be further development. Still merging into the remove-freesurfer branch, and continuing development from there.

@kdiers kdiers merged commit 9c16856 into Deep-MI:remove-freesurfer Jul 3, 2024
8 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants