Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read geometry #64

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Update read geometry #64

merged 8 commits into from
Aug 30, 2024

Conversation

kdiers
Copy link
Collaborator

@kdiers kdiers commented Aug 30, 2024

This PR changes the magic number that is used to assess the validity of presumed FreeSurfer surface files.

Previously, the computation of the magic number involved the application of the bit-shifting operator; however, this does not return identical results on all platforms. We therefore we disable it and return / compare the first three bytes of the file separately.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.89%. Comparing base (2de1c3f) to head (f577204).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
lapy/_read_geometry.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   34.91%   34.89%   -0.02%     
==========================================
  Files          14       14              
  Lines        2366     2367       +1     
  Branches      297      299       +2     
==========================================
  Hits          826      826              
- Misses       1456     1457       +1     
  Partials       84       84              
Flag Coverage Δ
unittests 34.89% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-reuter m-reuter merged commit 3f1d94e into Deep-MI:main Aug 30, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants