fix missing MFA session events#2371

Open

wojcik91 wants to merge 15 commits intodevfrom

fix_mfa_connect_event

Contributor

wojcik91 commented Mar 17, 2026

Add missing MFA-connected event. Also handle emitting events during MFA re-authorization.

Closes #2356 and #1965

wojcik91 added 11 commits

March 16, 2026 17:10


          emit disconnect events during MFA reconnect

c4b7dff


          add connected/disconnected events helpers

519288f


          emit connected event for new mfa sessions

0406dca


          update session manager tests

a11c0f1


          formatting

c04c88b


          support mfa events in frontend

33e9af2


          cleanup

98b6f1b


          disconnect both types of sessions on MFA re-auth

d14fec7


          handle event routing for both types of disconnects

1934a17


          update tests

ff82cad


          formatting

ca445dd

wojcik91 self-assigned this

filipslezaklab previously approved these changes

View reviewed changes

wojcik91 requested a review from Copilot

March 17, 2026 08:29

Copilot started reviewing on behalf of wojcik91

March 17, 2026 08:29

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

wojcik91 requested a review from Copilot

March 17, 2026 08:54

Copilot started reviewing on behalf of wojcik91

March 17, 2026 08:54

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/defguard_session_manager/src/session_state.rs Outdated Show resolved Hide resolved

crates/defguard_session_manager/src/session_state.rs Outdated Show resolved Hide resolved


          review fixes

8a95cf7

wojcik91 dismissed filipslezaklab’s stale review via

8a95cf7

March 17, 2026 09:53

wojcik91 requested a review from Copilot

March 17, 2026 09:53

Copilot started reviewing on behalf of wojcik91

March 17, 2026 09:53

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/defguard_core/src/grpc/proxy/client_mfa.rs Outdated Show resolved Hide resolved


          more review fixes

19c4263

wojcik91 requested a review from Copilot

March 17, 2026 10:28

Copilot started reviewing on behalf of wojcik91

March 17, 2026 10:29

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/defguard_session_manager/src/session_state.rs Show resolved Hide resolved


          fix for new mfa sessions

2bfe6ee

wojcik91 requested a review from Copilot

March 17, 2026 10:58

Copilot started reviewing on behalf of wojcik91

March 17, 2026 10:58

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/defguard_session_manager/src/lib.rs Outdated Show resolved Hide resolved

crates/defguard_core/src/grpc/proxy/client_mfa.rs Show resolved Hide resolved


          remove unnecessary conditional

b745494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet