fix service port references #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseiser
reviewed
Sep 26, 2025
| - port: {{ .Values.service.grpc.port }} | ||
| targetPort: grpc | ||
| protocol: UDP | ||
| protocol: TCP |
There was a problem hiding this comment.
Isnt this supposed to be UDP? I thought it was the actual wireguard VPN connection.
There was a problem hiding this comment.
Yes, this should indeed remain as UDP, but the service should be renamed to avoid confusion
|
In reading this, I think there is going to be a problem running in AWS atleast. The service would need configured to be exposed as an NLB. Which is not a problem. The issue though, is the NLB would need a way to determine that the POD is healthy, and you can not do a UDP health check, so it would expect some TCP/HTTP port/path that could it hit to actually decide the pod is able to have traffic routed to it. |
moubctez
previously approved these changes
Sep 29, 2025
moubctez
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98