-
Notifications
You must be signed in to change notification settings - Fork 1.8k
auditlog: switch to pghistory #13587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
valentijnscholten
wants to merge
9
commits into
DefectDojo:dev
Choose a base branch
from
valentijnscholten:pghistory-for-real
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
auditlog: switch to pghistory #13587
valentijnscholten
wants to merge
9
commits into
DefectDojo:dev
from
valentijnscholten:pghistory-for-real
+820
−1,109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Converted back to draft as we need to align the merge/release with Pro. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
New Migration
Adding a new migration file. Take care when merging.
settings_changes
Needs changes to settings.py based on changes in settings.dist.py included in this PR
ui
unittests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13169 we introducted
django-pghistoryas an alternative auditlog solution. The goal has always been to move todjango-pghistory, which is what this PR does now that we have had some time to test it.This PR:
DD_AUDITLOG_TYPEdjango-auditlogdjango-auditlogI tried removing the
django-auditlogas a dependency, but this has some complications. We may have to postpone this a bit to not have everything in one release.The additional code that would be needed for that remove be seen in the PR in my fork against this branch: