-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add bandits fun #4927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add bandits fun #4927
Conversation
|
The bandits adapter exports: |
noateden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert changes in package-lock.json and updated contract addresses
|
The bandits adapter exports: |
| const liquidationEvent = | ||
| "event Liquidated(address indexed user, uint256 goldSeized, uint256 collateralSeized)"; | ||
|
|
||
| const PAIR_CONTRACT = "0x8BE489CaF675c008269Befd5933D7BF6c660Ee53"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you counting volume of this pair is trading volume?
| eventAbi: buyEvent, | ||
| }); | ||
| for (const l of buy) { | ||
| dailyFees.add(STABLE_TOKEN, (l.amountInAfterFee * 100) / 98); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding trading amount to fee?
| }); | ||
| for (const l of liquidations) { | ||
| dailyFees.add(STABLE_TOKEN, l.collateralSeized); | ||
| dailyFees.add(GOLD_TOKEN, l.goldSeized); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding debts seized as fees?
noateden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review your adapter, I think you're counting fees wrong
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package.json/package-lock.jsonfile as part of your changesName (to be shown on DefiLlama):
Bandits
Twitter Link:
https://x.com/banditsdotfun
List of audit links if any:
TODO
Website Link:
https://bandits.fun
Logo (High resolution, will be shown with rounded borders):
TODO
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
BNB Smart Chain
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Perpetual Buying Machine.
Token address and ticker if any:
TODO
Category (full list at https://defillama.com/categories) *Please choose only one:
DEX
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):