Skip to content

Add blob fees calculation and metric for EIP-4844 transactions #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pyoneerC wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add blob fees calculation and metric for EIP-4844 transactions #4947

pyoneerC wants to merge 1 commit into from
+16 −4

Conversation

@pyoneerC
Copy link
Contributor

@pyoneerC pyoneerC commented Dec 6, 2025 •
edited
Loading

blob fees. lmk if sm bad.

closes #4937

@llamabutler
Copy link

llamabutler commented Dec 6, 2025

The ethereum adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees ethereum

🦙 Running ETHEREUM adapter 🦙
---------------------------------------------------
Start Date:	Fri, 05 Dec 2025 18:31:17 GMT
End Date:	Sat, 06 Dec 2025 18:31:17 GMT
---------------------------------------------------

------ ERROR ------
Error: INDEXA_DB not set
    at getConnection (/home/runner/work/dimension-adapters/dimension-adapters/helpers/indexer.ts:10:24)
    at queryIndexer (/home/runner/work/dimension-adapters/dimension-adapters/helpers/indexer.ts:30:22)
INDEXA_DB not set

@noateden noateden self-assigned this Dec 8, 2025
noateden
noateden reviewed Dec 8, 2025
View reviewed changes
fees/ethereum/index.ts

dailyFees.addGasToken(baseFees * 10 ** 18, METRIC.TRANSACTION_BASE_FEES)
dailyFees.addGasToken(priorityFees * 10 ** 18, METRIC.TRANSACTION_PRIORITY_FEES)
dailyFees.addGasToken(blobFees * 10 ** 18, METRIC.TRANSACTION_BLOB_FEES)
Copy link
Contributor

@noateden noateden Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is blob fee included in base fees?

noateden
noateden reviewed Dec 8, 2025
View reviewed changes
fees/ethereum/index.ts
dailyFees.addGasToken(blobFees * 10 ** 18, METRIC.TRANSACTION_BLOB_FEES)

dailyRevenue.addGasToken(baseFees * 10 ** 18, METRIC.TRANSACTION_BASE_FEES)
dailyRevenue.addGasToken(blobFees * 10 ** 18, METRIC.TRANSACTION_BLOB_FEES)
Copy link
Contributor

@noateden noateden Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were all blob transactions fees burned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noateden noateden noateden left review comments

Assignees

@noateden noateden

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Track ethereum blob fees

3 participants

@pyoneerC @llamabutler @noateden