-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add xStocks fee and revenue #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The xstocks adapter exports: |
treeoflife2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
| }, | ||
| }, | ||
| methodology: { | ||
| Fees: "Up to 0.50% of your investment's value is charged when entering and exiting the investment", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who charges this fee backedFi or xStocks?
https://docs.xstocks.fi/overview/issuance-and-redemption
https://docs.backed.fi/frequently-asked-questions#how-does-backed-make-money
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also track backedFi, so we can route the fees going to backedFi in their own adapter, and xStocks fees in their own adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @treeoflife2, good catch – I did not notice that you are already tracking backedFi.
I think xStocks is just a product line of backedFi and it does not take any direct fees on-chain. So everything should be moved to the backedFi adapter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@treeoflife2 backedFi has a larger set of products including the one listed on xStocks. if i update the backedFi adapter to include all these tokens for TVL counting, what happens to overlapping one with xStocks? should we remote xStocks entirely?
xstocks : https://xstocks.com/products
backedfi : https://assets.backed.fi/legal-documentation/product-database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes if xStocks doesn't take any fees, then let's track the backedFi fees and you can remove the xStocks adapter
| @@ -0,0 +1,398 @@ | |||
| [ | |||
| { | |||
| "name": "ABTx Abbott xStock", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some way to make it dynamic? or reuse the tvl adapter,
https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/xstocks/index.js
as that will be upto date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll look to see if i can find an API endpoint or something.
btw, is there any way to read a json file from adapters repository inside the dimension repo? so i can reuse the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do the simple http request, add try catch block which throw error incase anything changes
closes #4817