Skip to content

Conversation

@0x4r45h
Copy link
Contributor

@0x4r45h 0x4r45h commented Dec 9, 2025

closes #4817

@llamabutler
Copy link

The xstocks adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees xstocks

🦙 Running XSTOCKS adapter 🦙
---------------------------------------------------
Start Date:	Mon, 08 Dec 2025 01:26:04 GMT
End Date:	Tue, 09 Dec 2025 01:26:04 GMT
---------------------------------------------------

------ ERROR ------
Error: Request failed with status code 401
    at _queryDune (/home/runner/work/dimension-adapters/dimension-adapters/helpers/dune.ts:219:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
Request failed with status code 401

@treeoflife2 treeoflife2 self-assigned this Dec 9, 2025
Copy link
Member

@treeoflife2 treeoflife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

},
},
methodology: {
Fees: "Up to 0.50% of your investment's value is charged when entering and exiting the investment",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also track backedFi, so we can route the fees going to backedFi in their own adapter, and xStocks fees in their own adapter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @treeoflife2, good catch – I did not notice that you are already tracking backedFi.
I think xStocks is just a product line of backedFi and it does not take any direct fees on-chain. So everything should be moved to the backedFi adapter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treeoflife2 backedFi has a larger set of products including the one listed on xStocks. if i update the backedFi adapter to include all these tokens for TVL counting, what happens to overlapping one with xStocks? should we remote xStocks entirely?

xstocks : https://xstocks.com/products
backedfi : https://assets.backed.fi/legal-documentation/product-database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes if xStocks doesn't take any fees, then let's track the backedFi fees and you can remove the xStocks adapter

@@ -0,0 +1,398 @@
[
{
"name": "ABTx Abbott xStock",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some way to make it dynamic? or reuse the tvl adapter,

https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/xstocks/index.js

as that will be upto date

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll look to see if i can find an API endpoint or something.

btw, is there any way to read a json file from adapters repository inside the dimension repo? so i can reuse the list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do the simple http request, add try catch block which throw error incase anything changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track xStocks Fee/Revenue

3 participants