New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `url.JoinPath` to consume `-server` argument without string mashing #14

Merged

jasikpark merged 1 commit into main from improve-url-building

Jun 11, 2024

Contributor

jasikpark commented Jun 11, 2024 •

edited

Loading

This will prevent passing http://localhost:9001/ from generating an enrollment path of //v2/enroll, which will generate a 404 on the server.


          Use url.JoinPath to consume -server argument without string mashing

fef080e

jasikpark requested review from johnmaguire and brad-defined

June 11, 2024 20:08

johnmaguire approved these changes

View reviewed changes

jasikpark merged commit 4589547 into main

2 checks passed

jasikpark deleted the improve-url-building branch

June 11, 2024 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet