Fix logic error causing panic storing nil #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a test I received the following error:
Basically, we try to decode a "derp" error when receiving a 500. If we fail to decode it, we store a "generic" error, otherwise we store the fancy typed error.
Except I forgot an "else" so even in error, we'd try to overwrite the generic error with a nil error. It's kind of lucky that atomics don't allow storing nil values, or we might've missed this.