New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise layer distribution. #58

Closed

erwin-mulder opened this issue Dec 5, 2024 · 1 comment · Fixed by #59

Assignees

Collaborator

erwin-mulder commented Dec 5, 2024

After discussions with stakeholders, we need to revise the layer distribution somewhat:

salinity should NOT use the vertical profiles (in input AND output)
integration of the layer quantities should strictly use positive or negative part of the profile, so we have to integrate exactly up to or from the zero point of the profile.

erwin-mulder self-assigned this

erwin-mulder linked a pull request

that will close this issue

58 revise layer distribution #59

Merged

Collaborator Author

erwin-mulder commented Dec 10, 2024 •

edited

Loading

Additional issues:

Currently water volumes are communicated to ZSF only for the 'from' laterals. This is not correct, for distribution we need to use the 'to' volumes instead.

add communication of 'to' volumes from dfm to zsf in dimr config.
add set_var in ZSF for both volumes:
- rename existing volume quantities to 'volume_from_*'
- add new 'volume_to_*' quantities and associated volume arrays.
use 'to' volumes to distribute quantities instead of the current ones.

Salinity in layers that have no discharge should be set to zero.

add a masking in sealock_distribute_results for salinity (depends on availability of discharge layers)

vrielin mentioned this issue

58 revise layer distribution #59

Merged

erwin-mulder closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment