Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 DStability changes #170

Closed
breinbaas opened this issue Jan 4, 2024 · 4 comments
Closed

2024 DStability changes #170

breinbaas opened this issue Jan 4, 2024 · 4 comments
Assignees
Labels
bug Something isn't working d-stability

Comments

@breinbaas
Copy link
Collaborator

breinbaas commented Jan 4, 2024

Creating a DStability model and then trying to calculate it using 2024.01 results in the following error;

Output file generated but parsing of ... 34-1_0.45-0.81_0.stix failed.

pydantic.error_wrappers.ValidationError: 2 validation errors for UpliftVanParticleSwarmResult
ResultThreshold
  extra fields not permitted (type=value_error.extra)
SlipPlaneResults
  extra fields not permitted (type=value_error.extra)

This is due to missing fields in the geolib code.

@breinbaas breinbaas self-assigned this Jan 4, 2024
@breinbaas breinbaas added bug Something isn't working d-stability labels Jan 4, 2024
@breinbaas
Copy link
Collaborator Author

fixed for upliftvanparticleswarm -> needed to set

ResultThreshold: float = 0.0

instead of

ResultThreshold: Optional[float] = None

because the latter leads to models that cannot be opened in 2024.01

@breinbaas
Copy link
Collaborator Author

breinbaas commented Jan 4, 2024

fixed bishop brute force / spencer genetic algorithm where fields were added as well

@breinbaas
Copy link
Collaborator Author

There seems to be a bugfix already; #163

Not sure which code is better!

@breinbaas breinbaas linked a pull request Jan 4, 2024 that will close this issue
@wfaustmann
Copy link
Collaborator

Fixed in GEOLib v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working d-stability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants