Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose missing args in BishopBruteForceresult #163

Closed

Conversation

MatthiasHauthDeltares
Copy link
Collaborator

@MatthiasHauthDeltares MatthiasHauthDeltares commented Dec 5, 2023

Parsing or executing a file which had BishopBruteForce as calculation method would raise an error because of the missing exposed attributes for the class BishopBruteForceResults

@MatthiasHauthDeltares MatthiasHauthDeltares added bug Something isn't working d-stability labels Dec 5, 2023
@carloslubbers
Copy link
Contributor

These properties are part of the upcoming D-Stability 2024.01 release, so this is not something we can release just yet. We were planning on making a PR for that later as well, but if you want to you could maybe start that PR off with this change (and the missing properties for the other calculation types as well!)

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@breinbaas
Copy link
Collaborator

seems like I've been working on that issue as well, my code is a little more complicated but if this works then it's fine, see #170

This was referenced Jan 4, 2024
@breinbaas
Copy link
Collaborator

If I use this option I get the following error when parsing a stix file;

Error: Project could not be opened.
Error converting value {null} to type 'System.Double'. Path 'ResultThreshold', line 2, position 27.

I have solved this using ResultThreshold: Optional[float] = 0.0 although this does differ from the other options that are set to None

@wfaustmann
Copy link
Collaborator

Fixed in GEOLib v2.3.0 using a similar approach as proposed here

@wfaustmann wfaustmann closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working d-stability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants