Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

719: Add Fortran scientific notation support in .tim files #720

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

arthurvd
Copy link
Member

@arthurvd arthurvd commented Dec 9, 2024

Fixes #719

@arthurvd arthurvd requested a review from MAfarrag December 9, 2024 11:12
class FortranUtils:
"""Utility class for Fortran specific conventions."""

_scientific_exp_d_notation_regex = re.compile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this expression only captures the integer fortran style, and now it is only being used in the Tim model right ?

hydrolib/core/dflowfm/tim/models.py Show resolved Hide resolved
hydrolib/core/utils.py Show resolved Hide resolved
hydrolib/core/utils.py Outdated Show resolved Hide resolved
@arthurvd arthurvd merged commit 93573a3 into main Dec 17, 2024
12 checks passed
@arthurvd arthurvd deleted the fix/719_fortran_d_exp_timeseries branch December 17, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimModel filetype should support "1D0" Fortran scientific notation too
2 participants