Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1134 refresh timeseries #1136

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

1134 refresh timeseries #1136

wants to merge 13 commits into from

Conversation

amarkensteijn
Copy link
Collaborator

Pull Request Template

Description

Please provide a brief description of the changes made in this pull request.

Screenshots (if applicable)

If there are any visual changes, please attach screenshots here.

Link to documentation (if applicable)

Add link to public Github pages (only documentation about configuration)

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

@amarkensteijn amarkensteijn linked an issue Dec 17, 2024 that may be closed by this pull request
@amarkensteijn
Copy link
Collaborator Author

Currently, the charts get recreated every time the data changes, which lead to frequent 'flickering' of the chart (see also this comment). Created this issue to look into this.

@amarkensteijn
Copy link
Collaborator Author

The interval / automatic refresh still needs to be implemented for the elevation charts

@amarkensteijn
Copy link
Collaborator Author

It still flickers sometimes. As far as I've been able to determine, this is due to the v-show and the LoadingOverlay based on the isLoading prop. We should move the loading indicator to each indiviual series, e.g. in the legend tag. We could consider an initial loader indicator on the full chart panel when opening it for the first time, untill the chart config have loaded or untill as least one series has data. Something like this is done for the RWsOS viewer

Do not use the display config title as id (and v-for key) for all timeseries charts within that display
Draw and scale the chart at initiation, once the data is loaded
@amarkensteijn amarkensteijn force-pushed the 1134-refresh-timeseries branch from edb5851 to 223ceed Compare January 9, 2025 14:21
The indicator on chart level causes the chart to flicker in case the data is requested again
@amarkensteijn
Copy link
Collaborator Author

The interval / automatic refresh still needs to be implemented for the elevation charts

Has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh timeseries
1 participant