Skip to content

Commit

Permalink
snakecase segment_length
Browse files Browse the repository at this point in the history
  • Loading branch information
Santonia27 committed Dec 12, 2024
1 parent cc7edcc commit ee01f89
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions examples/add_roadnetwork.ipynb

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions hydromt_fiat/workflows/exposure_vector.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,11 @@ def setup_roads(
roads[
[
"max_damage_structure",
"Segment Length",
"segment_length",
]
] = get_max_potential_damage_roads(roads, road_damage)
elif isinstance(road_damage, (int, float)) or road_damage is None:
roads["Segment Length"] = road_length
roads["segment_length"] = road_length
roads["max_damage_structure"] = road_damage

# Convert crs to exposure buildings crs
Expand Down
6 changes: 3 additions & 3 deletions hydromt_fiat/workflows/roads.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def get_max_potential_damage_roads(
roads = gpd.GeoDataFrame(
{
"lanes": pd.to_numeric(roads["lanes"], errors="coerce"),
"Segment Length": roads.length,
"segment_length": roads.length,
"geometry": roads["geometry"],
}
)
Expand All @@ -31,15 +31,15 @@ def get_max_potential_damage_roads(
roads["damage_value"] = roads["lanes"].map(damage_dic)

# Potentially convert the length to meters
roads["max_damage_structure"] = roads["damage_value"] * roads["Segment Length"]
roads["max_damage_structure"] = roads["damage_value"] * roads["segment_length"]
if unit == "meters" or unit == "metre" or unit == "m":
roads["max_damage_structure"] = roads["max_damage_structure"] * 0.3048
else:
print(
"You are using the wrong unit for the segment length. Please use <'foot/feet/ft'> or <'meters/metre/m'>"
)

return roads[["max_damage_structure", "Segment Length"]]
return roads[["max_damage_structure", "segment_length"]]


def get_road_lengths(roads):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_roads.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def test_setup_roads(case):
"extract_method",
"ground_flht",
"max_damage_structure",
"Segment Length",
"segment_length",
]
assert set(required_columns) == set(exposure.columns)

Expand Down

0 comments on commit ee01f89

Please sign in to comment.