-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road network notebook #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! There are just two things that I suggest:
- Showing the damage function as a graph as well (you can take code from the example for building a fiat model globally);
- Distinguishing between data inputs and the created fiat model in the folder structure (in examples\data\road_network). That way, we can put the resulting fiat model folder in the gitignore and they don't get added to the repository.
Furthermore, I see some merge conflicts. You can solve them by checking out the Road_network_notebook branch and pulling/updating the code from main and resolving the conflicts arising there.
After fixing those issues we can merge it all into main!
Okay great, I included the visualization of the damage curve and tried to clarify the difference of the data input and the model output (also added the model output to .gitignore) The merge conflicts should be resolved now 👍 |
Looks good!! |
Create Notebook and data folder for example jupyter notebook to create FIAT model with road network.