Update to newest Delft version and setup impacted population #406
Conversation
Santonia27
commented
Oct 30, 2024
•
Santonia27
commented
- update all headers to align with the newest Delft Fiat version
- add function to setup_impacted_population
- add clipping of exposure data to hazard if used setup_hazard. In the future will be added to delft fiat to have some tolerance.
* make variable names compatible with new Delft Fiat version * add gfh attribute to setup exposure buildings * update primary and secondary classification * add docstring, add ground elevation unit, fix naming structure content * setup populatoin remove geometry * remove capitalized * update gis * uncomment zonal means
…orund elevation unit
…ple step function
…setup_impacted_population
…setup_impacted_population
|
Could you resolve the merge conflict? I'll review after. thanks |
…setup_impacted_population
…setup_impacted_population
…setup_impacted_population
…setup_impacted_population
tests/test_roads.py
Outdated
| "fn_damages_structure", | ||
| "max_damages_structure", |
There was a problem hiding this comment.
@dalmijn @Santonia27 I get the error below in Delft-FIAT 0.20 and think this can be solved by changing damages in these lines with damage.
2024-11-27 15:41:40 ERROR For type: 'damage' no matching columns were found for fn_damage_* and max_damage_* columns.
| "fn_damages_structure", | |
| "max_damages_structure", | |
| "fn_damage_structure", | |
| "max_damage_structure", |
…setup_impacted_population
…setup_impacted_population
hydromt_fiat/api/hydromt_fiat_vm.py
Outdated
| self.new_ground_floor_height(config_yaml) | ||
| elif "Additional Attributes" in item: | ||
| self.new_additional_attributes(config_yaml) | ||
| elif "Ground Elevation" in item: | ||
| elif "ground_elevtn" in item: | ||
| self.new_ground_elevation(config_yaml) | ||
| elif "Max Potential Damages" in item: |
There was a problem hiding this comment.
where is this used and why does it have spaces?
There was a problem hiding this comment.
its used in delft dashboard.
What do you mean with spaces?
hydromt_fiat/workflows/gis.py
Outdated
| @@ -221,6 +223,20 @@ def join_spatial_data( | |||
| right_gdf.at[index, 'geometry'] = largest_polygon | |||
| assert len(right_gdf.geom_type.unique()) == 1 | |||
|
|
|||
There was a problem hiding this comment.
It seems that this part is repeated 3 times
There was a problem hiding this comment.
oh oops i think i accidently copied the blocks
hydromt_fiat/workflows/roads.py
Outdated
| @@ -17,7 +17,7 @@ def get_max_potential_damage_roads( | |||
| roads = gpd.GeoDataFrame( | |||
| { | |||
| "lanes": pd.to_numeric(roads["lanes"], errors="coerce"), | |||
| "segment_length": roads.length, | |||
| "Segment Length": roads.length, | |||
There was a problem hiding this comment.
is the idea that we only use the snake case for the mandatory FIAT columns?
There was a problem hiding this comment.
since it s not used in fiat i didnt update it but I changed it now to snakecase also
|
