-
-
Notifications
You must be signed in to change notification settings - Fork 18
Django 5 upgrade #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 5 upgrade #405
Conversation
8469cfa to
3e490fb
Compare
|
Per discussion on slack, I've removed This PR has also been deployed to https://stage.electionleaflets.org/ |
| from leaflets.models import Leaflet, LeafletImage | ||
| from leaflets.tests.conftest import TEST_IMAGE_LOCATION | ||
|
|
||
| TEST_STORAGES = settings.STORAGES.copy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Do we need to deepcopy() here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we do. Done in bc08192
|
Its annoying that django-s3file isn't on PyPI but having looked over codingjoe/django-s3file@5.5.7...6.0.0 I don't think there is anything we need in it for django 5.2 compatibility so I reckon lets just stick on 5.5.7 rather than switch to a VCS dependency. I raised an issue upstream about it anyway. |
c2d4021 to
bc08192
Compare
|
will leave it with you to:
and merge |
bc08192 to
4e5f138
Compare
Upgrade to django
5.2.7. Also bumps the following packages:Notes:
django-braceslatest release doesn't officially support django>4.2.It looks like there is a "spiritual successor" called django-brackets that is for django>4.2and does the same things. However, for the stuff we're using fromdjango-braces(LoginRequiredMixin,StaffuserRequiredMixin) doesn't seem broken , so not sure if it's worth switching from braces to brackets?django-formtoolsbump that caused issues outlined in upgrade django-formtools==2.5.1 (attempt 2) EveryElection#2537 doesn't seem to break anything on this repo. I'm not sure why and worried I'm missing something so it would be good to double check this assumption.django-s3filehas a 6.0.0 release on github that supports django5.1, but its not on PyPi for some reason.django-debug-toolbarwasn't actually set up properly so I did that.Deprecations:
dc-django-utilsand replaced STATICFILES_STORAGE with the STORAGES dict. We weren't importing the default pipeline settings from dc_utils in this repo so I also implemented that.dc-design-systemto the latest version but didn't need to update anything.django-querystring-tagbecause its part of core django now.