Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Assertions endpoint #73

Closed
vteague opened this issue May 10, 2024 · 4 comments · Fixed by #139
Closed

Generate Assertions endpoint #73

vteague opened this issue May 10, 2024 · 4 comments · Fixed by #139
Assignees

Comments

@vteague
Copy link
Member

vteague commented May 10, 2024

Implement the Generate Assertions endpoint, calling the /generate-assertions endpoint in raire-service.

@vteague vteague converted this from a draft issue May 10, 2024
@vteague
Copy link
Member Author

vteague commented May 10, 2024

Note this will need to deal with error responses from raire-service, e.g. TIED_WINNERS. These are returned in the http header and (in most cases) should be reported to the user.

@vteague
Copy link
Member Author

vteague commented May 18, 2024

Also note this will have to update the winner field in the data structure subsequently used to generate reports. This was not done in the prototype. I think this is ContestResult, but need to check.

We debated whether it's appropriate to have an IRVContestResult for just this reason.

@vteague
Copy link
Member Author

vteague commented May 26, 2024

Use ContestResult::setWinners and ContestResult::setLosers. IRV has only one winner, so every candidate who is not the winner is a loser.
Explicitly set both to blank if an error is returned (because otherwise corla will fill them with plurality winners based on preference-mentions, which is meaningless).

@vteague vteague moved this from Todo to In Progress in CO IRV RLA Jun 23, 2024
@vteague vteague self-assigned this Jun 23, 2024
@vteague
Copy link
Member Author

vteague commented Jun 26, 2024

The persistence and proper reporting of winners are now in new cards: #136, #137

@vteague vteague linked a pull request Jun 28, 2024 that will close this issue
@vteague vteague moved this from In Progress to Testing & Review in CO IRV RLA Jun 28, 2024
@github-project-automation github-project-automation bot moved this from Testing & Review to Done in CO IRV RLA Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant