73 generate assertions endpoint #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-assertions-endpoint
…ate-assertions-endpoint
…rameters, badData and other parent-class utilities.
…o ensure no interference with real database.
AndrewConway
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LOGGER.debug(String.format("%s %s.", prefix, "Received Generate Assertions request."));
ends in two periods.
There was a problem hiding this comment.
also LOGGER.debug(String.format("%s %s.", prefix, "Completed assertion generation for all IRV contests."));
same double period.
final String prefix = "[generateAssertions]";
doesn't match the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the main work of the generate-assertions endpoint, with tests.
Note that there are not (yet) any API tests - these tests only check the behaviour of the function that does the work of the endpoint.