Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76 irvcomparisonaudit #138

Merged
merged 13 commits into from
Jun 30, 2024
Merged

76 irvcomparisonaudit #138

merged 13 commits into from
Jun 30, 2024

Conversation

michelleblom
Copy link
Member

No description provided.

@michelleblom
Added tests for Assertion::computeInitialOptimisticSampleSize().
273ce8f
@michelleblom
Added tests for Assertion::computeOptimisticSampleSize().
16b2bd8
@michelleblom
Added NEB assertions tests for computing estimated sample sizes.
eb3e5a3
@michelleblom
Added test for estimated sample size computation for NEN assertions.
632c470
@michelleblom
Removed unused import statement.
3332749
@michelleblom
Added test for initialSamplesToAudit() in IRVComparisonAudit.
4ccc54b
@michelleblom
Refactoring to include CastVoteRecord mocks in AssertionTests, and ma…
c045e98 
…ke use of those across NENAssertionTests, NEBAssertionTests, and IRVComparisonAuditTests.
@michelleblom
Removed unused imports.
f1efe07
@michelleblom
Continued to flesh out IRVComparisonAudit tests, specifically for dis…
e125432 
…crepancy computation and recording. Still need to test recording of understatements, removal of discrepancies, and risk measurement.
@michelleblom
Added tests for recording of understatements.
a729850
@michelleblom
Added some todos detailing the tests that still need to be written fo…
27ec3d7 
…r assertions and IRVComparisonAudits.
@michelleblom michelleblom requested a review from vteague June 27, 2024 23:57
vteague
vteague approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@vteague vteague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. I found one typo, which I just fixed.

vteague added 2 commits June 30, 2024 21:26
@vteague
Merge remote-tracking branch 'refs/remotes/origin/main' into 76-irvco…
d2b5fed 
…mparisonaudit

# Conflicts:
#	server/eclipse-project/src/test/java/au/org/democracydevelopers/corla/model/IRVComparisonAuditTests.java
@vteague
Merged main.
8a4948c
@vteague vteague merged commit f5d0f38 into main Jun 30, 2024
1 check passed
@vteague vteague deleted the 76-irvcomparisonaudit branch June 30, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vteague vteague vteague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michelleblom @vteague