New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

73 generate assertions endpoint #147

Merged

vteague merged 2 commits into main from 73-generate-assertions-endpoint

Jul 2, 2024

Member

vteague commented Jul 2, 2024

Changes to error handling and logging based on @AndrewConway 's review.

vteague added 2 commits

July 2, 2024 21:49


          Correct name in prefix.

697d9ce


          Corrections based on @AndrewConway's review.

4cc18d7

vteague requested review from umbernhard, AndrewConway, michelleblom and charliecarlton

July 2, 2024 12:04

AndrewConway approved these changes

View reviewed changes

AndrewConway left a comment

All good. Nice to change a mixture of format and string concatenation to just format.

vteague merged commit 035da55 into main

1 check passed

vteague deleted the 73-generate-assertions-endpoint branch

July 2, 2024 12:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet