Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client changes from prototype #148

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Client changes from prototype #148

merged 7 commits into from
Jul 8, 2024

Conversation

vteague
Copy link
Member

@vteague vteague commented Jul 4, 2024

This merges the prototype client UI into the updated branch of colorado-rla. Also added a button for getting assertions as CSV.

Note this is not intended as production code - it's a no-frills interface with basic functionality.

@vteague vteague requested a review from charliecarlton July 4, 2024 12:20
Copy link
Collaborator

@charliecarlton charliecarlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good although I noticed a couple of things that could be (but probably not) related.

  1. When I estimate sample sizes on this branch it fails and I get this error:
    INFO MatcherFilter:162 - The requested route [/estimate-sample-sizes] has not been mapped in Spark for Accept: [text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,/;q=0.8,application/signed-exchange;v=b3;q=0.7]

  2. Definitely unrelated to this case but noticed while testing: When I Reset the database to start a new audit, the assertions tables do not get emptied. Not sure if that's been an issue for you all or if you have a different way of getting everything set up for a new audit.

@vteague
Copy link
Member Author

vteague commented Jul 8, 2024

Thanks for your reviews @charliecarlton

  1. Estimate-sample-sizes isn't currently expected to work - that endpoint is still on the todo list.
  2. Good catch re ensuring assertion tables are deleted when resetting the database - I've added a card at Ensure assertion tables are deleted when database is reset #149

@vteague vteague closed this Jul 8, 2024
@vteague vteague reopened this Jul 8, 2024
@vteague vteague merged commit 7ef5085 into main Jul 8, 2024
2 checks passed
@vteague vteague deleted the ClientChangesFromPrototype branch July 8, 2024 23:35
@vteague vteague restored the ClientChangesFromPrototype branch July 8, 2024 23:35
@vteague vteague deleted the ClientChangesFromPrototype branch July 8, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants