227 adopt refactoring of testclasswithdatabases from model tests #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a small function to load other database scripts.
…sts to use DD's version.
umbernhard
approved these changes
Jan 8, 2025
| Properties hibernateProperties = new Properties(); | ||
| hibernateProperties.setProperty("hibernate.driver", "org.postgresql.Driver"); | ||
| hibernateProperties.setProperty("hibernate.url", postgres.getJdbcUrl()); | ||
| hibernateProperties.setProperty("hibernate.user", postgres.getUsername()); |
There was a problem hiding this comment.
it's so much nicer that this is loaded from a config dynamically instead of my hardcoded version!
| import us.freeandfair.corla.math.Audit; | ||
| import us.freeandfair.corla.model.CVRContestInfo; | ||
| import us.freeandfair.corla.model.CastVoteRecord; | ||
| import us.freeandfair.corla.model.CastVoteRecord.RecordType; |
There was a problem hiding this comment.
I'm guessing the changes in this file are just because you're now loading the data via an SQL file instead of manually adding it?
vteague
deleted the
227-adopt-refactoring-of-testclasswithdatabases-from-model-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the refactoring done by DD to get TestClassWithDatabases to use test.properties with the refactoring done by @umbernhard to bring a lot of the repeated functions into the base class.