More models tests #234
Merged
More models tests #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleblom
approved these changes
Jan 17, 2025
| @@ -33,8 +34,8 @@ public void AuditInfoTest() { | |||
| gson = new GsonBuilder().setPrettyPrinting().create(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It would be good to have some pre-method comments to identify what aspects of the code base each test is targeting.
There was a problem hiding this comment.
I will make sure I start doing this!
| } | ||
|
|
||
| @Test | ||
| public void testAuditInfoNoContests() { |
There was a problem hiding this comment.
For things that are used across tests and that aren't going to change -- like "electionType", seeds, risk limits -- you could make them final static members of the class and reuse them.
For variables that are basically just going to be set and then not reassigned later, you could make them final (eg electionDate, publicMeetingDate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.