Merge pull request #59 from DemocracyDevelopers/IgnoreTestFailsFalse

Set ignore = false for test failures.
DemocracyDevelopers · Apr 5, 2024 · 369f5b9 · 369f5b9
2 parents 273196f + 04010ac
commit 369f5b9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/run_unit_tests.yaml b/.github/workflows/run_unit_tests.yaml
@@ -46,5 +46,5 @@ jobs:
       run: mvn -B -DskipTests package --file pom.xml
 
     - name: Test
-      run: mvn -B -Dmaven.test.failure.ignore=true test
+      run: mvn -B -Dmaven.test.failure.ignore=false test
 
diff --git a/.../java/au/org/democracydevelopers/raireservice/request/GenerateAssertionsRequestTests.java b/.../java/au/org/democracydevelopers/raireservice/request/GenerateAssertionsRequestTests.java
@@ -51,7 +51,7 @@ public class GenerateAssertionsRequestTests {
    */
   private final List<String> candidates = List.of("Alice");
   private final String ballina = "Ballina Mayoral";
-  private final String byron = "Byron";
+  private final String multiCounty = "Multi-County Contest 1";
 
   /**
    * A valid request for an IRV contest is valid.
@@ -68,7 +68,7 @@ public void validRequestForSingleIRVContestIsValid() {
    */
   @Test
   public void validRequestForCrossCountyIRVContestIsValid() {
-    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(byron, 100, 100,
+    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(multiCounty, 100, 100,
           candidates);
     assertDoesNotThrow(() -> validRequest.Validate(contestRepository));
   }
@@ -188,7 +188,7 @@ public void requestWithWhitespaceCandidateNameIsInvalid() {
   @Test
   public void ZeroTotalAuditableBallotsIsInvalid() {
     GenerateAssertionsRequest validRequest
-        = new GenerateAssertionsRequest(byron, 0, 100, candidates);
+        = new GenerateAssertionsRequest(multiCounty, 0, 100, candidates);
     Exception ex = assertThrows(RequestValidationException.class, () -> validRequest.Validate(contestRepository));
     assertTrue(ex.getMessage().contains("Non-positive total auditable ballots"));
   }
@@ -199,7 +199,7 @@ public void ZeroTotalAuditableBallotsIsInvalid() {
    */
   @Test
   public void negativeTotalAuditableBallotsIsInvalid() {
-    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(byron,
+    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(ballina,
         -10, 100, candidates);
     Exception ex = assertThrows(RequestValidationException.class, () -> validRequest.Validate(contestRepository));
     assertTrue(ex.getMessage().contains("Non-positive total auditable ballots"));
@@ -210,7 +210,7 @@ public void negativeTotalAuditableBallotsIsInvalid() {
    */
   @Test
   public void ZeroTimeProvisionForResultIsInvalid() {
-    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(byron,
+    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(ballina,
           100, 0, candidates);
     Exception ex = assertThrows(RequestValidationException.class, () -> validRequest.Validate(contestRepository));
     assertTrue(ex.getMessage().contains("Non-positive time limit"));
@@ -222,7 +222,7 @@ public void ZeroTimeProvisionForResultIsInvalid() {
    */
   @Test
   public void negativeTimeProvisionForResultIsInvalid() {
-    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(byron, 100, -100,
+    GenerateAssertionsRequest validRequest = new GenerateAssertionsRequest(ballina, 100, -100,
         candidates);
     Exception ex = assertThrows(RequestValidationException.class, () -> validRequest.Validate(contestRepository));
     assertTrue(ex.getMessage().contains("Non-positive time limit"));

diff --git a/src/test/java/au/org/democracydevelopers/raireservice/request/GetAssertionsRequestTests.java b/src/test/java/au/org/democracydevelopers/raireservice/request/GetAssertionsRequestTests.java
@@ -52,7 +52,7 @@ public class GetAssertionsRequestTests {
    */
   @Test
   public void validRequestForIRVContestIsValid() {
-    GetAssertionsRequest validRequest = new GetAssertionsRequest("Byron", List.of("Alice"), BigDecimal.valueOf(0.03));
+    GetAssertionsRequest validRequest = new GetAssertionsRequest("Ballina Mayoral", List.of("Alice"), BigDecimal.valueOf(0.03));
     assertDoesNotThrow(() -> validRequest.Validate(contestRepository));
   }