refactor: Get language options from the constructor to avoid memory r…

…eallocations (#255)
DentallApp · Jul 1, 2024 · 9e460be · 9e460be
1 parent d1adc3d
commit 9e460be
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/HostApplication/Extensions/SwaggerGen.cs b/src/HostApplication/Extensions/SwaggerGen.cs
@@ -48,15 +48,21 @@ public static IServiceCollection AddSwagger(this IServiceCollection services)
 
     private class AcceptLanguageHeaderParameter(IConfiguration configuration) : IOperationFilter
     {
-        public void Apply(OpenApiOperation operation, OperationFilterContext context)
+        private readonly IList<IOpenApiAny> _languageOptions = CreateLanguageOptions(configuration);
+        private readonly string _defaultLanguage = configuration.GetDefaultLanguage();
+
+        private static List<IOpenApiAny> CreateLanguageOptions(IConfiguration configuration)
         {
-            operation.Parameters ??= [];
             var languageOptions = new List<IOpenApiAny>();
             var languages = configuration.GetLanguages();
-            var defaultLanguage = configuration.GetDefaultLanguage();
-            foreach (var language in languages) 
+            foreach (var language in languages)
                 languageOptions.Add(new OpenApiString(language));
+            return languageOptions;
+        }
 
+        public void Apply(OpenApiOperation operation, OperationFilterContext context)
+        {
+            operation.Parameters ??= [];
             operation.Parameters.Add(new OpenApiParameter
             {
                 Name = "Accept-Language",
@@ -66,8 +72,8 @@ public void Apply(OpenApiOperation operation, OperationFilterContext context)
                 Schema = new OpenApiSchema
                 {
                     Type = "string",
-                    Default = new OpenApiString(defaultLanguage),
-                    Enum = languageOptions
+                    Default = new OpenApiString(_defaultLanguage),
+                    Enum = _languageOptions
                 }
             });
         }