Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exposing the method called ConfigureWebApplicationBuilder to the plugins #239

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

MrDave1999
Copy link
Member

@MrDave1999 MrDave1999 commented Mar 6, 2024

  • Replace the PluginStartup interface with IDependencyServicesRegisterer (it is a more descriptive name).
  • Replace the ConfigureWebApplicationBuilder method with RegisterServices(IServiceCollection, IConfiguration).

The consumer should not be able to use the type called WebApplicationBuilder in its plugins, because it has the absolute freedom to build the web application through the Build method and this does not make sense, since it is the responsibility of the host application.

…e plugins

* Replace the PluginStartup interface with IDependencyServicesRegisterer (it is a more descriptive name)

* Replace the ConfigureWebApplicationBuilder method with RegisterServices(IServiceCollection, IConfiguration).

The consumer should not be able to use the type called WebApplicationBuilder in its plugins, because it has the absolute freedom to build the web application through the Build() method and this does not make sense, since it is the responsibility of the host application.
@MrDave1999 MrDave1999 marked this pull request as ready for review March 6, 2024 20:06
@MrDave1999 MrDave1999 changed the title Avoid exposing the method called ConfigureWebApplicationBuilder Avoid exposing the method called ConfigureWebApplicationBuilder to the plugins Mar 6, 2024
@MrDave1999 MrDave1999 merged commit c726cbb into dev Mar 6, 2024
1 check passed
@MrDave1999 MrDave1999 deleted the patch-14 branch March 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant