Validate if the identity document is Ecuadorian #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the algorithm is contained in its own plugin project.
This is the default implementation in case no plugin registers its own implementation.
The algorithm had been implemented incorrectly. See https://www.skypack.dev/view/udv-ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to implement the algorithm in a plugin project and to be able to change the implementation from a configuration file (.env). Algorithm used: https://www.skypack.dev/view/udv-ec
For example, I could add this implementation:
Or I could exchange it for another one in the future:
In case there is no plugin loaded to validate the identity document, the host application will use a fake provider called
FakeIdentityDocument.The algorithm for verifying an identity document is highly dependent on the country in which the application is used, so it makes sense to decouple this logic from the host application.
This approach is very flexible, new implementations can be added without having to modify the host application code, allowing the assembly to be loaded dynamically.