Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Get language options from the constructor to avoid memory reallocations #255

Merged
merged 1 commit into from
Jul 1, 2024
Merged

refactor: Get language options from the constructor to avoid memory reallocations #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/HostApplication/Extensions/SwaggerGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,21 @@ public static IServiceCollection AddSwagger(this IServiceCollection services)

private class AcceptLanguageHeaderParameter(IConfiguration configuration) : IOperationFilter
{
public void Apply(OpenApiOperation operation, OperationFilterContext context)
private readonly IList<IOpenApiAny> _languageOptions = CreateLanguageOptions(configuration);
private readonly string _defaultLanguage = configuration.GetDefaultLanguage();

private static List<IOpenApiAny> CreateLanguageOptions(IConfiguration configuration)
{
operation.Parameters ??= [];
var languageOptions = new List<IOpenApiAny>();
var languages = configuration.GetLanguages();
var defaultLanguage = configuration.GetDefaultLanguage();
foreach (var language in languages)
foreach (var language in languages)
languageOptions.Add(new OpenApiString(language));
return languageOptions;
}

public void Apply(OpenApiOperation operation, OperationFilterContext context)
{
operation.Parameters ??= [];
operation.Parameters.Add(new OpenApiParameter
{
Name = "Accept-Language",
Expand All @@ -66,8 +72,8 @@ public void Apply(OpenApiOperation operation, OperationFilterContext context)
Schema = new OpenApiSchema
{
Type = "string",
Default = new OpenApiString(defaultLanguage),
Enum = languageOptions
Default = new OpenApiString(_defaultLanguage),
Enum = _languageOptions
}
});
}
Expand Down
Loading