Skip to content

Conversation

bastien-boussouf
Copy link
Contributor

@bastien-boussouf bastien-boussouf commented Mar 7, 2025

Description

While working on the repository, I figured I could probably make prettier and linting a bit more portable across platforms (I'm working on a mix of Windows / WSL / Linux setups).

The changes I propose are mainly directed at having an .editorconfig file that prettier automatically picks when running and that will also apply to the user IDE. I also propose to align the versions used in the workflow to the one declared in the package.json file.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@bastien-boussouf bastien-boussouf marked this pull request as ready for review March 27, 2025 22:24
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

@DenverCoder1 DenverCoder1 merged commit 8be19c1 into DenverCoder1:main Sep 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants