Add sanitizers support to project#581
Closed
winterheart wants to merge 1 commit intoDescentDevelopers:mainfrom
Closed
Add sanitizers support to project#581winterheart wants to merge 1 commit intoDescentDevelopers:mainfrom
winterheart wants to merge 1 commit intoDescentDevelopers:mainfrom
Conversation
8d1c271 to
b95d5b3
Compare
Contributor
|
That is quite a lot of a code for something as simple as (the ideal case of desktoplinux): |
Supported sanitizers controlled by configure options `SANITIZE_ADDRESS`, `SANITIZE_MEMORY`, `SANITIZE_THREAD` and `SANITIZE_UNDEFINED`. Sanitizers support added to main executable, shared script libraries and netcon libraries.
b95d5b3 to
8138923
Compare
Member
|
I agree that it's a lot of infrastructure and CMake code to maintain to add compiler flags, not sure it's a great addition. We have little incentive to have a flawless cross-platform ASAN integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supported sanitizers controlled by configure options
SANITIZE_ADDRESS,SANITIZE_MEMORY,SANITIZE_THREADandSANITIZE_UNDEFINED. Sanitizers support added to main executable, shared script libraries and netcon libraries.Pull Request Type
Description
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments