Revert "Grab keyboard when the game is not launched with -nomousegrab" #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1707ee1.
Under X11, grabbing the keyboard has negative side effect of rendering Alt-Tab useless in windowed mode. Multimedia volume keys are rendered useless in windowed or fullscreen mode. When execution of descent3 is suspended (e.g. when running under a debugger), it would be impossible to get out of it even in fullscreen mode, since the SDL handler does not run.
Looking at other games, I find that many other engines (chocolate-doom, gzdoom, yquake2, sauerbraten, but also gl-117) do not exercise keyboard grabbing either and only use relative mouse mode (mouse grab).
Pull Request Type
Related Issues
#665
Checklist