Generate ICHs benefitting from artifact anti-champion mods #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
approved these changes
Jan 2, 2023
|
Is this still valid with the current artifact configuration? |
|
needed defs dependency updates, re-running against current artifact, and a regex update. |
|
Yeah I was worried the regex would require tweaking each season anyway, but seems good to me. |
robojumper
force-pushed
the
breakermod-artifact-breakers
branch
from
06924fb to
26dc1c4
Compare
|
Okay, fixed it for this season (old mods weren't deprecated, new mods aren't gauntlet mods anymore) |
|
This still works as of season 23 |
delphiactual
force-pushed
the
breakermod-artifact-breakers
branch
from
43d6420 to
89adf65
Compare
|
@robojumper updated for TFS |
delphiactual
force-pushed
the
breakermod-artifact-breakers
branch
from
89adf65 to
6042a1a
Compare
delphiactual
force-pushed
the
breakermod-artifact-breakers
branch
from
afcf111 to
830dc52
Compare
update and warning .
delphiactual
force-pushed
the
breakermod-artifact-breakers
branch
from
bce8ca5 to
3974a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a DIM search filter that matches weapons with seasonal anti-champion mods in the artifact. Bungie keeps deprecating and re-adding the anti-champion mods every season with varying reliability, so I'm checking the artifact itself for safety.