add test for subscripting AbstractContextManager on 3.8

packages/pyright-internal/src/tests/samples/subscript_check.py

@@ -0,0 +1,10 @@
+from contextlib import AbstractContextManager
+from typing import ContextManager
+
+ContextManagerAlias = ContextManager
+AbstractContextManagerAlias = AbstractContextManager
+
+foo: ContextManagerAlias[None]
+bar: AbstractContextManagerAlias[None] # error
+baz: ContextManager[None]
+qux: AbstractContextManager[None] # error

packages/pyright-internal/src/tests/typeEvaluatorBased.test.ts

@@ -1,5 +1,6 @@
 import { BasedConfigOptions, ConfigOptions } from '../common/configOptions';
 import { DiagnosticRule } from '../common/diagnosticRules';
+import { pythonVersion3_8 } from '../common/pythonVersion';
 import { Uri } from '../common/uri/uri';
 import { UriEx } from '../common/uri/uriUtils';
 import { resolveSampleFilePath, typeAnalyzeSampleFiles, validateResultsButBased } from './testUtils';
@@ -75,3 +76,17 @@ test('reportInvalidCast', () => {
         ],
     });
 });
+
+test('subscript context manager types on 3.8', () => {
+    const configOptions = new ConfigOptions(Uri.empty());
+    configOptions.defaultPythonVersion = pythonVersion3_8;
+    const analysisResults = typeAnalyzeSampleFiles(['subscript_check.py'], configOptions);
+    const message =
+        'Subscript for class "AbstractContextManager" will generate runtime exception; enclose type annotation in quotes';
+    validateResultsButBased(analysisResults, {
+        errors: [
+            { code: DiagnosticRule.reportGeneralTypeIssues, line: 7, message },
+            { code: DiagnosticRule.reportGeneralTypeIssues, line: 9, message },
+        ],
+    });
+});