-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Check for rootPath property #8
Conversation
Seems like not all file systems have the rootPath property
Hey @curtishenson Sorry for the late response. I added 7fa52dc to your branch, it's purely cosmetic. This will be release with craft 5 support. Let us know if you need that for craft 4, as it can be easily backported. Thanks again ! |
Awesome! |
Hey @curtishenson & @nitriques, I'm relatively new to CraftCMS, and I may simply be missing a configuration or env variables somewhere, but while using the Local fs and setting the craft-cloudflare-stream setting to use form input instead of public URL. The After reverting the changes, this PR implemented (locally) the This is a long-winded way of saying, either would you be able to point me in the direction of what config value I may need to include, or this change accidentally breaks Local FS. Thanks in advance, and I appreciate your efforts here. |
Hey @pixelcab !
Welcome! We DO want beginners to be able to use the extension, so this is great ! We do use the local FS all the time with this plugin and it works pretty well on our end. The Could I ask you to use Also, could you provide the complete stack trace of the error you are seeing with the current code ? Thanks ! |
Re #8 This PR seems to be needed for craft 5
Seems like not all file systems have the rootPath property.
We ran into an issue similar to #7 but with the servd assets plugin. Which is S3 under the hood.
Checking for rootPath and defaulting to an empty string seems to make everything work again.
I wasn't able to test a local filesystem to see if this caused any issues there.