TabPanel: Added focus to the selected tab after initialization (T1277409)#29989
Merged
pharret31 merged 10 commits intoDevExpress:25_1from May 27, 2025
Merged
Conversation
pharret31
force-pushed
the
25_1_208-tabpanel-tabs---the-scroll-postition-resets
branch
from
8aa0f75 to
acb7514
Compare
packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js
Outdated
Show resolved
Hide resolved
ksercs
reviewed
May 27, 2025
| this._$container.append(this._$wrapper); | ||
|
|
||
| const { focusStateEnabled, selectedIndex } = this.option(); | ||
| if (focusStateEnabled) { |
Contributor
There was a problem hiding this comment.
Why should we do it only when focusStateEnabled? Is it a condition for all places where focusedElement is updated/used?
Contributor
Author
There was a problem hiding this comment.
As far as I understand if focusStateEnabled is false it won't use focus states and there won't be an issue with them the users faced
ksercs
reviewed
May 27, 2025
packages/devextreme/testing/tests/DevExpress.ui.widgets/tabPanel.tests.js
Outdated
Show resolved
Hide resolved
pharret31
changed the title
anna-shakhova
approved these changes
May 27, 2025
pharret31
deleted the
25_1_208-tabpanel-tabs---the-scroll-postition-resets
branch
pharret31
added a commit
to pharret31/DevExtreme
that referenced
this pull request
May 27, 2025
This was referenced May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.