Skip to content

Conversation

@sjbur
Copy link
Contributor

@sjbur sjbur commented Dec 2, 2025

No description provided.

@sjbur sjbur self-assigned this Dec 2, 2025
@sjbur sjbur added the 25_2 label Dec 2, 2025
@sjbur sjbur marked this pull request as ready for review December 4, 2025 12:04
@sjbur sjbur requested a review from a team as a code owner December 4, 2025 12:04
Copilot AI review requested due to automatic review settings December 4, 2025 12:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Scheduler component to better support legacy popup layouts with custom form configurations, particularly for React Storybook demonstrations. The changes ensure that the recurrence rule state is properly synchronized between the form and the recurrence form component, especially when toggling between "never" and recurring appointments.

Key Changes

  • Made recurrenceRule property public in RecurrenceForm class to allow direct external access and manipulation
  • Modified recurrence value saving logic to always save (removed conditional guard), ensuring state consistency
  • Updated React Storybook with a comprehensive legacy popup example using a custom switch-based recurrence toggle

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/scheduler/appointment_popup/m_recurrence_form.ts Changed recurrenceRule from private property with getter/setter to public property, enabling external components to directly access and modify the recurrence rule state
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts Added explicit recurrence rule resets when "never" is selected, removed conditional check in saveRecurrenceValue() to ensure rule is always saved, and added call to updateRecurrenceFormValues() for proper state synchronization
apps/react-storybook/stories/scheduler/SchedulerFormCustomization.stories.tsx Enhanced LegacyPopup story with React Scheduler component, custom popup toolbar, and switch-based recurrence editor that demonstrates legacy popup layout with manual form control

Copilot AI review requested due to automatic review settings December 5, 2025 14:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

Copilot AI review requested due to automatic review settings December 8, 2025 08:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

const buttonInstance = $(firstButton).dxButton('instance');
expect(buttonInstance?.option('disabled')).toBe(true);
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add more tests:

  • We have added code to preserve values in recurrence form for repeat end editors. So we need to test case when:
  1. User opens recurrence form
  2. Changes value for repeat end editors (both count and until)
  3. User goes back to main form
  4. User selects different frequency in repeat editor (not 'never')
  5. User open recurrence form again
  6. Check that values in count, until and repeat end values are preserved
  • We added code to set 'disabled' to repeat end editors on content ready. We need to cover it with tests

Copilot AI review requested due to automatic review settings December 9, 2025 09:56
@Tucchhaa Tucchhaa self-assigned this Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings December 9, 2025 11:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings December 9, 2025 15:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@sjbur sjbur merged commit 5aff64a into DevExpress:25_2 Dec 9, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants