fix:: 하드코딩된 변수 dto에 static으로 선언

DevKor-github · Nov 30, 2024 · 21582bb · 21582bb
1 parent 5e36f6d
commit 21582bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/course/course.service.ts b/src/course/course.service.ts
@@ -443,7 +443,7 @@ export class CourseService {
   ): Promise<CourseEntity[]> {
     const { keyword, cursorId, year, semester } = searchCoursesWithKeywordDto;
 
-    const LIMIT = 21;
+    const LIMIT = PaginatedCoursesDto.LIMIT;
 
     let queryBuilder = this.courseRepository
       .createQueryBuilder('course')

diff --git a/src/course/dto/paginated-courses.dto.ts b/src/course/dto/paginated-courses.dto.ts
@@ -2,6 +2,8 @@ import { ApiProperty } from '@nestjs/swagger';
 import { CommonCourseResponseDto } from './common-course-response.dto';
 
 export class PaginatedCoursesDto {
+  static readonly LIMIT = 21;
+
   @ApiProperty({ description: '다음 페이지 존재 여부' })
   hasNextPage: boolean;