feat: add golangci-lint linter integration with v2.x support#51
Merged
ikjeong merged 8 commits intoDevSymphony:mainfrom Dec 12, 2025
Merged
feat: add golangci-lint linter integration with v2.x support#51ikjeong merged 8 commits intoDevSymphony:mainfrom
ikjeong merged 8 commits intoDevSymphony:mainfrom
Conversation
- Implement Linter interface for golangci-lint - Add binary download and installation from GitHub releases - Support cross-platform detection (Linux, macOS, Windows) - Handle tar.gz and zip extraction based on platform - Implement execution logic with JSON output format - Parse golangci-lint JSON output to Violation structs - Handle exit code 1 as success (violations found) - Create temporary config file management
- Implement Converter interface for golangci-lint - Add LLM-based rule to linter mapping - Generate .golangci.yml YAML configuration - Support 9 rule categories (bugs, style, performance, etc.) - Include comprehensive linter list in LLM prompt - Validate linter names and generated configuration
- Add register.go with init() function - Update bootstrap.go with blank import - Integrate with Symphony CLI linter system
- Add linter_test.go with platform detection tests - Add parser_test.go with JSON parsing tests - Add converter_test.go with YAML generation tests - Achieve >80% code coverage - Test cross-platform compatibility - Test error handling and edge cases
- Run go mod tidy - Ensure gopkg.in/yaml.v3 is available
- Change output format flag from --out-format to --format in the golangci-lint command. - Ensure compatibility with the latest golangci-lint version.
sehwan505
reviewed
Dec 12, 2025
Contributor
sehwan505
left a comment
sehwan505
left a comment
There was a problem hiding this comment.
지금 lint가 안맞아요. 이외에는 LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/linter/golangcilint/패키지 신규 생성linter.go: GitHub releases에서 바이너리 다운로드/설치, 크로스 플랫폼 지원 (Linux, macOS, Windows)executor.go: golangci-lint v2.x CLI 실행 (--output.json.path,--show-stats=false,./...패턴)parser.go: JSON 출력 파싱 및 Violation 구조체 변환converter.go: LLM 기반 규칙→린터 매핑, v2.x formatters/linters 분리 지원register.go: 글로벌 린터 레지스트리 등록--format플래그 대신--output.json.path stdout사용./...패턴 사용 후 결과 필터링../../../처리)