Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little image adjustments #2

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Little image adjustments #2

wants to merge 49 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2015

Hi,
I just wanto to propose a couple of changes to the images.
First, the background of the header: it is repeated, so I simply cut 20px from the left side. In this way the repetition is quite more discreet.
Second, I reflected the bird, so during the scroll the title is more legible. I would also have decreased the left margin of the .fore-bird to -445px, giving a bit of space to the title*.

I created another branch, in which I have experienced a lot. If you have some time to waste, please, give a look (https://github.com/LoogleeTk/Parallax-on-the-Web-DevTips-/tree/personal) and let me know what you think.

* I have done it in the other branch.

Andrea Leone added 2 commits April 6, 2015 19:05
A lot of changes!
- Header background cutted
- Bird reflected
@ajspeller
Copy link

I especially like the reflection of the bird.

systimotic added a commit to systimotic/Parallax-on-the-Web-DevTips- that referenced this pull request Apr 7, 2015
Here is episode 2 done in vanilla JS!
@travisneilson
Copy link
Contributor

Hey @loogleetk Thanks so much for taking this on and making it your own. I love that. I love that github really puts this code in your hands and enables you to do things like this.

I don't think I'm going to pull this in though. I accepted pull requests on another video series I made and it mostly confused people. I have about 4 more videos completed on this series. Pulling this in would kind of disrupt the flow of that.

I really think it's great that you did this though. It's wonderful.

@ghost
Copy link
Author

ghost commented Apr 13, 2015

Yeah, I understand. I'll keep on hacking on both.

  • The series is becoming more and more awesome by the way. ;)

@systimotic
Copy link

Idea: when you think you're done with the series, you can do a little "fixing up" episode, where you go through and fix, clean up and make things better.

@travisneilson
Copy link
Contributor

Great idea @TimohStudios , thank you so much! I'm going to make a video where I explain these pull requests (giving credit to you guys, of course) and pull them in.

If you can resolve this Merge Conflict before next Tuesday (26th) I'll be sure to get this on the video so everyone can see the awesome work you did!

@ghost
Copy link
Author

ghost commented May 24, 2015

Sorry @travisneilson, even though I tried a lot, I couldn't solve the merge conflicts.
If you wanna see my work, I have uploaded it on my domain, but if you want to have a look to the code, you need to download the .zip from GitHub.

@travisneilson
Copy link
Contributor

Oh cool, Your version looks cool!

Tell you what. I'll point out your work and scroll through your version (as it's such a big departure, maybe it's best not to pull it in.)

If you did want to submit something else, maybe a small fix or optimization. Maybe that cool Preloader :) —I'd be able to pull in an isolated thing like that...

Thanks for your work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants