Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added builder pattern #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added builder pattern #20

wants to merge 1 commit into from

Conversation

guggens
Copy link

@guggens guggens commented Oct 15, 2020

its hacktoberfest, so here you go with a builder kotlin example.

@Devansh-Maurya
Copy link
Owner

Thanks @guggens !
Will look into this tomorrow.

Devansh-Maurya
Devansh-Maurya requested changes Oct 17, 2020
View reviewed changes
Copy link
Owner

@Devansh-Maurya Devansh-Maurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the package structure of the repo. Create a separate file for the main() method

README.md
* **Example:** [Building a book](src/builder)

Proxy is
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devansh-Maurya Devansh-Maurya Devansh-Maurya requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guggens @Devansh-Maurya