Encapsulate svc preprocessing #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 21, 2023 20:57
…lChannelProcessor (prev StaticVirtualChannel) and ChunkProcessor
Coverage Report 🤖 ⚙️Past: New: Diff: +1.50% [this comment will be updated automatically] |
CBenoit
reviewed
Sep 23, 2023
There was a problem hiding this comment.
Looks reasonable to me! I left a few comments.
@pacmancoder
Since this is targeting your branch, I think it’s best if you merge it yourself once you reviewed it (make sure to squash)
EDIT: I see in the CI that something is not compiling
added 2 commits
September 24, 2023 11:36
pacmancoder
reviewed
Sep 25, 2023
| /// Usually returned by the channel-specific methods. | ||
| pub struct SvcRequest<C> { | ||
| pub struct SvcMessagesForProcessor<P: StaticVirtualChannelProcessor> { |
There was a problem hiding this comment.
I think For could be omitted: SvcProcessorMessage
pacmancoder
added a commit
that referenced
this pull request
Sep 26, 2023
This branch also includes refactoring changes by @ibeckermayer from #196 and #197
pacmancoder
added a commit
that referenced
this pull request
Sep 26, 2023
This branch also includes refactoring changes by @ibeckermayer from #196 and #197 Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
CBenoit
pushed a commit
that referenced
this pull request
Sep 27, 2023
Includes refactoring changes by @ibeckermayer from #196 and #197 Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.