Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds decoding for ServerDeviceAnnounceResponse #199

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Adds decoding for ServerDeviceAnnounceResponse #199

merged 4 commits into from
Oct 2, 2023

Conversation

ibeckermayer
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 23259
Covered lines: 15639 (67.24%)

New:
Total lines: 23305
Covered lines: 15640 (67.11%)

Diff: -0.13%

[this comment will be updated automatically]

CBenoit
CBenoit approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looking good to me otherwise

Leaving open until tomorrow if you want to modify something

crates/ironrdp-rdpdr/src/pdu/efs.rs Outdated Show resolved Hide resolved
crates/ironrdp-rdpdr/src/lib.rs Outdated Show resolved Hide resolved
@CBenoit CBenoit self-assigned this Sep 29, 2023
@CBenoit CBenoit force-pushed the feat/ServerDeviceAnnounceResponse branch from b8fe97a to 2b9e643 Compare October 2, 2023 15:01
@CBenoit CBenoit enabled auto-merge (squash) October 2, 2023 15:02
@CBenoit
Copy link
Member

CBenoit commented Oct 2, 2023 •
edited
Loading

Thank you!

(I rebased on master to fix the conflicts and pushed a commit to address the lints.)

@CBenoit CBenoit merged commit d8c6efa into master Oct 2, 2023
@CBenoit CBenoit deleted the feat/ServerDeviceAnnounceResponse branch October 2, 2023 15:08
@CBenoit CBenoit mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacmancoder pacmancoder pacmancoder approved these changes

@CBenoit CBenoit CBenoit approved these changes

Assignees

@CBenoit CBenoit

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibeckermayer @CBenoit @pacmancoder