Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): update release-plz.toml #618

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Dec 16, 2024

Pass --no-verify to cargo publish when publishing *-native crates.

*-native crates may have all kinds of system requirements depending on the platform. We can only check for the current platform when cargo publish is invoked, all the others are effectively unverified. For this reason, it's not worth complexifying the release-crates.yml workflow. We already verify all targets properly in the CI.

image

Pass `--no-verify` to `cargo publish` when publishing `*-native` crates.

`*-native` crates may have all kinds of system requirements depending
on the platform. We can only check for the current platform when cargo
publish is invoked, all the others are effectively unverified. For this
reason, it's not worth complexifying the release-crates.yml workflow. We
already verify all targets properly in the CI.
Copy link

Coverage Report 🤖 ⚙️

Past:
Total lines: 29433
Covered lines: 18629 (63.29%)

New:
Total lines: 29433
Covered lines: 18625 (63.28%)

Diff: -0.01%

[this comment will be updated automatically]

@CBenoit CBenoit merged commit c01017f into master Dec 16, 2024
9 checks passed
@CBenoit CBenoit deleted the chore/update-release-plz.toml branch December 16, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants