Remainder from hlsl PT and stuff moved out of bxdf unit test #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d change to compile time depth
Comment on lines
+65
to
+66
| template<class F, typename float_t, uint32_t Depth=6> // F has function __call(x) | ||
| struct AdaptiveSimpson |
Member
There was a problem hiding this comment.
Fshould be required to haveoperator()(x)not__call(this is one is meant for statics- make a concept for the above
float_tyou can default todecltype(declval<F>()(0))
There was a problem hiding this comment.
Also f should be NBL_ConST_REF_ARG and not NBL_REF_ARG (it doesn't make sense otherwise, you want there to be no inner mutable state because it can't be sensitive to order its getting called in)
| template<class F, typename float_t, uint32_t Depth=6> // F has function __call(x) | ||
| struct AdaptiveSimpson | ||
| { | ||
| static float_t __call(NBL_REF_ARG(F) f, float_t x0, float_t x1, float_t eps = 1e-6) |
There was a problem hiding this comment.
documentation, what's eps used for ?
Comment on lines
+19
to
+31
| static const float32_t3 RGB_LUT[256]; | ||
|
|
||
| static float32_t3 map(float x) | ||
| { | ||
| x = hlsl::clamp(x, 0.f, 1.f); | ||
| int i = int(x * 255.f); | ||
| int j = hlsl::min(255, i+1); | ||
| float s = x * 255.f - float(i); | ||
| return RGB_LUT[i] + (RGB_LUT[j] - RGB_LUT[i]) * s; | ||
| } | ||
| }; | ||
|
|
||
| inline const float32_t3 Turbo::RGB_LUT[256] = { |
There was a problem hiding this comment.
use the correct NBL_ macros for out of line constexpr array declarations and definitions
| { | ||
| static const float32_t3 RGB_LUT[256]; | ||
|
|
||
| static float32_t3 map(float x) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.