Skip to content

Withdrawal from Strategy, Governance Integration Tests, Governance Read Views#236

Merged
Devsol-01 merged 2 commits intoDevsol-01:mainfrom
OtowoSamuel:main
Feb 25, 2026
Merged

Withdrawal from Strategy, Governance Integration Tests, Governance Read Views#236
Devsol-01 merged 2 commits intoDevsol-01:mainfrom
OtowoSamuel:main

Conversation

@OtowoSamuel
Copy link
Contributor

Closes #220
Closes #221
Closes #226


Pull Request Description

This PR addresses the following issues in the Nestera protocol smart contracts:

  1. Fixed deposit routing to strategies, implemented a strategy registry, and defined a strategy interface.
  2. Added withdrawal logic from strategies, including robust handling for underflow, partial, and negative withdrawals.
  3. Integrated governance lifecycle tests and attack scenario tests, resolving errors related to trait imports and result handling.
  4. Implemented and exposed new governance read-only views for proposals and votes.
  5. Ensured all tests pass, including the governance lifecycle test, by updating voting logic to require a majority for proposal queuing.
  6. Applied formatting corrections to comply with cargo fmt standards.
  7. Addressed all compilation and test errors; only warnings remain (deprecated event publishing and unused code).

The codebase is now error-free, fully tested, and CI-ready.

@vercel
Copy link

vercel bot commented Feb 25, 2026

@OtowoSamuel is attempting to deploy a commit to the devsol-01's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Devsol-01 Devsol-01 merged commit d12b07f into Devsol-01:main Feb 25, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Withdrawal from Strategy Governance Integration Tests Governance Read Views

2 participants